refactor: refactor codebase using very_good_analysis

packages/cohost/analysis_options.yaml

@@ -2,4 +2,7 @@ include: package:very_good_analysis/analysis_options.yaml
 
 linter:
   rules:
-    public_member_api_docs: false
+    public_member_api_docs: false
+
+analyzer:
+  exclude: [ '**.g.dart' ]

packages/cohost/lib/cohost.dart

@@ -1,5 +1,3 @@
-library;
-
 export 'src/models/attachment.dart';
 export 'src/models/blocks.dart';
 export 'src/models/post.dart';

packages/cohost/lib/src/models/attachment.dart

@@ -14,6 +14,9 @@ class Attachment {
     required this.height,
   });
 
+  factory Attachment.fromJson(Map<String, dynamic> json) =>
+      _$AttachmentFromJson(json);
+
   final String attachmentId;
   final String altText;
   final Uri previewURL;
@@ -23,9 +26,6 @@ class Attachment {
   final int height;
 
   Map<String, dynamic> toJson() => _$AttachmentToJson(this);
-
-  factory Attachment.fromJson(Map<String, dynamic> json) =>
-      _$AttachmentFromJson(json);
 }
 
 enum AttachmentKind {

packages/cohost/lib/src/models/blocks.dart

@@ -4,12 +4,10 @@ import 'package:json_annotation/json_annotation.dart';
 part 'blocks.g.dart';
 
 sealed class Block {
-  BlockType get type;
-
   const Block();
 
   factory Block.fromJson(Map<String, dynamic> json) {
-    final type = BlockType.values.firstWhere((e) => json["type"] == e.name);
+    final type = BlockType.values.firstWhere((e) => json['type'] == e.name);
 
     final block = switch (type) {
       BlockType.attachment => AttachmentBlock.fromJson(json),
@@ -21,6 +19,8 @@ sealed class Block {
     return block;
   }
 
+  BlockType get type;
+
   Map<String, dynamic> toJson();
 }
 
@@ -30,6 +30,9 @@ enum BlockType { attachment, markdown }
 class AttachmentBlock extends Block {
   const AttachmentBlock({required this.attachment});
 
+  factory AttachmentBlock.fromJson(Map<String, dynamic> json) =>
+      _$AttachmentBlockFromJson(json);
+
   @override
   BlockType get type => BlockType.attachment;
 
@@ -37,15 +40,15 @@ class AttachmentBlock extends Block {
 
   @override
   Map<String, dynamic> toJson() => _$AttachmentBlockToJson(this);
-
-  factory AttachmentBlock.fromJson(Map<String, dynamic> json) =>
-      _$AttachmentBlockFromJson(json);
 }
 
 @JsonSerializable()
 class MarkdownBlock extends Block {
   const MarkdownBlock({required this.markdown});
 
+  factory MarkdownBlock.fromJson(Map<String, dynamic> json) =>
+      _$MarkdownBlockFromJson(json);
+
   @override
   BlockType get type => BlockType.markdown;
 
@@ -53,7 +56,4 @@ class MarkdownBlock extends Block {
 
   @override
   Map<String, dynamic> toJson() => _$MarkdownBlockToJson(this);
-
-  factory MarkdownBlock.fromJson(Map<String, dynamic> json) =>
-      _$MarkdownBlockFromJson(json);
 }

packages/cohost/lib/src/models/post.dart

@@ -40,6 +40,8 @@ class Post {
     required this.responseToAskId,
   });
 
+  factory Post.fromJson(Map<String, dynamic> json) => _$PostFromJson(json);
+
   final int postId;
   final String headline;
   final DateTime publishedAt;
@@ -73,6 +75,4 @@ class Post {
   final String? responseToAskId;
 
   Map<String, dynamic> toJson() => _$PostToJson(this);
-
-  factory Post.fromJson(Map<String, dynamic> json) => _$PostFromJson(json);
 }

packages/cohost/lib/src/models/project.dart

@@ -27,6 +27,9 @@ class Project {
     required this.isSelfProject,
   });
 
+  factory Project.fromJson(Map<String, dynamic> json) =>
+      _$ProjectFromJson(json);
+
   final int projectId;
   final String handle;
   final String displayName;
@@ -49,9 +52,6 @@ class Project {
   final bool? isSelfProject;
 
   Map<String, dynamic> toJson() => _$ProjectToJson(this);
-
-  factory Project.fromJson(Map<String, dynamic> json) =>
-      _$ProjectFromJson(json);
 }
 
 @JsonSerializable()
@@ -62,14 +62,14 @@ class ContactCardLink {
     required this.service,
   });
 
+  factory ContactCardLink.fromJson(Map<String, dynamic> json) =>
+      _$ContactCardLinkFromJson(json);
+
   final ContactCardLinkVisiblity visibility;
   final String value;
   final String service;
 
   Map<String, dynamic> toJson() => _$ContactCardLinkToJson(this);
-
-  factory ContactCardLink.fromJson(Map<String, dynamic> json) =>
-      _$ContactCardLinkFromJson(json);
 }
 
 enum ContactCardLinkVisiblity { public }
@@ -93,12 +93,12 @@ class AskSettings {
     required this.requireLoggedInAnon,
   });
 
+  factory AskSettings.fromJson(Map<String, dynamic> json) =>
+      _$AskSettingsFromJson(json);
+
   final bool enabled;
   final bool allowAnon;
   final bool requireLoggedInAnon;
 
   Map<String, dynamic> toJson() => _$AskSettingsToJson(this);
-
-  factory AskSettings.fromJson(Map<String, dynamic> json) =>
-      _$AskSettingsFromJson(json);
 }

packages/cohost/lib/src/models/project.g.dart

@@ -101,7 +101,7 @@ ContactCardLink _$ContactCardLinkFromJson(Map<String, dynamic> json) =>
 
 Map<String, dynamic> _$ContactCardLinkToJson(ContactCardLink instance) =>
     <String, dynamic>{
-      'visibility': _$ContactCardLinkVisiblityEnumMap[instance.visibility]!,
+      'visibility': _$ContactCardLinkVisiblityEnumMap[instance.visibility],
       'value': instance.value,
       'service': instance.service,
     };

packages/kaiteki/analysis_options.yaml

@@ -1,4 +1,6 @@
-include: package:flutter_lints/flutter.yaml
+include: package:very_good_analysis/analysis_options.yaml
+
+
 
 analyzer:
   plugins:
@@ -7,68 +9,10 @@ analyzer:
     - '**.g.dart'
     - 'lib/l10n/**'
   errors:
-    missing_enum_constant_in_switch: ignore
-    # Ignoring TODO comments since they're obnoxious
-    # to see within the problem list and can be easily
-    # viewed with the todo lists within the IDE.
     todo: ignore
     fixme: ignore
     hack: ignore
 
-custom_lint:
-  rules:
-    # Unreliable, triggers on variables and methods returning expected Widget type.
-    - missing_provider_scope: false
-
 linter:
   rules:
-    avoid_type_to_string: true
-    avoid_positional_boolean_parameters: false
-
-    # Unnecessary code
-    avoid_redundant_argument_values: true
-    avoid_types_on_closure_parameters: true
-    noop_primitive_operations: true
-    unnecessary_await_in_return: true
-    unnecessary_lambdas: true
-    unnecessary_null_aware_assignments: true
-    unnecessary_null_checks: true
-    unnecessary_parenthesis: true
-    unnecessary_statements: true
-    omit_local_variable_types: true
-
-    # Code style
-    prefer_double_quotes: true
-    always_declare_return_types: true
-    avoid_void_async: true
-    join_return_with_assignment: true
-    only_throw_errors: true
-    prefer_constructors_over_static_methods: true
-    prefer_final_in_for_each: true
-    prefer_final_locals: true
-    require_trailing_commas: true
-    use_named_constants: true
-    use_setters_to_change_properties: true
-    use_string_buffers: true
-    use_test_throws_matchers: true
-    use_super_parameters: true
-
-    # Dart features
-    avoid_classes_with_only_static_members: true
-    avoid_returning_this: true
-    cascade_invocations: true
-    prefer_asserts_in_initializer_lists: true
-    prefer_if_elements_to_conditional_expressions: true
-
-    # Sorting
-    directives_ordering: true
-    sort_pub_dependencies: true
-    sort_unnamed_constructors_first: true
-
-    # Naming conventions
-    flutter_style_todos: true
-    use_to_and_as_if_applicable: true
-    
-    # Flutter
-    sized_box_shrink_expand: true
-    use_decorated_box: true
+    public_member_api_docs: false