Commit graph

137 commits

Author SHA1 Message Date
syuilo
3f4101d17b use node 16 2022-06-04 17:26:56 +09:00
Johann150
102012aa9d fix: add id for activitypub follows (#8689)
* add id for activitypub follows

* fix lint

* fix: follower must be local, followee must be remote

Misskey will only use ActivityPub follow requests for users that are local
and are requesting to follow a remote user. This check is to ensure that
this endpoint can not be used by other services or instances.

* fix: missing import

* render block with id

* fix comment
2022-06-04 13:52:42 +09:00
Johann150
8e296b2398 fix: always remove completed tasks (#8771) 2022-05-31 17:54:02 +09:00
Johann150
ec47b46423 refactor: improve code quality (#8751)
* remove unnecessary if

`Array.prototype.some` already returns a boolean so an if to return
true or false is completely unnecessary in this case.

* perf: use count instead of find

When using `count` instead of `findOneBy`, the data is not
unnecessarily loaded.

* remove duplicate null check

The variable is checked for null in the lines above and the function
returns if so. Therefore, it can not be null at this point.

* simplify `getJsonSchema`

Because the assigned value is `null` and the used keys are only
shallow, use of `nestedProperty.set` seems inappropriate. Because the
value is not read, the initial for loop can be replaced by a `for..in`
loop.

Since all keys will be assigned `null`, the condition of the ternary
expression in the nested function will always be true. Therefore the
recursion case will never happen. With this the nested function can be
eliminated.

* remove duplicate condition

The code above already checks `dragging` and returns if it is truthy.
Checking it again later is therefore unnecessary.

To make this more obvious the `return` is removed in favour of using
an if...else construct.

* remove impossible "unknown" time

The `ago` variable will always be a number and all non-negative numbers
are already covered by other cases, the negative case is handled with
`future` so there is no case when `unkown` could be achieved.
2022-05-29 15:15:52 +09:00
Johann150
c2ddc5286c refactor: temporary files (#8713)
* simplify temporary files for thumbnails

Because only a single file will be written to the directory, creating a
separate directory seems unnecessary. If only a temporary file is created,
the code from `createTemp` can be reused here as well.

* refactor: deduplicate code for temporary files/directories

To follow the DRY principle, the same code should not be duplicated
across different files. Instead an already existing function is used.

Because temporary directories are also create in multiple locations,
a function for this is also newly added to reduce duplication.

* fix: clean up identicon temp files

The temporary files for identicons are not reused and can be deleted
after they are fully read. This condition is met when the stream is closed
and so the file can be cleaned up using the events API of the stream.

* fix: ensure cleanup is called when download fails

* fix: ensure cleanup is called in error conditions

This covers import/export queue jobs and is mostly just wrapping all
code in a try...finally statement where the finally runs the cleanup.

* fix: use correct type instead of `any`
2022-05-25 16:50:22 +09:00
Johann150
d6046c75aa fix: wrong type for isVisibleForMe 2022-05-24 10:12:42 +02:00
Johann150
848ac5a75d fix(activitypub): add authorization checks (#8534)
* fix spelling

* fix(activitypub): add authorization checks
2022-05-19 20:40:16 +09:00
Johann150
306b825ae2 enhance: uniform theme color (#8702)
* enhance: make theme color format uniform

All newly fetched instance theme colors will be uniformely formatted
as hashtag followed by 6 hexadecimal digits.

Colors are checked for validity and invalid colors are not handled.

* better input validation for own theme color

* migration to unify theme color formats

Fixes theme colors of other instances as well as the local instance.

* add changelog entry

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2022-05-19 09:54:45 +02:00
MeiMei
f0cdc636c4 fix: Unable to generate video thumbnails (#8696)
* fix: Unable to generate video thumbnails

* CHANGELOG
2022-05-19 16:19:23 +09:00
Johann150
370b9deac2 fix _misskey_content of quote renotes (#8533) 2022-05-01 19:23:34 +09:00
tamaina
1df07ded68 feat: Improve Push Notification (#7667)
* clean up

* ev => data

* refactor

* clean up

* add type

* antenna

* channel

* fix

* add Packed type

* add PackedRef

* fix lint

* add emoji schema

* add reversiGame

* add reversiMatching

* remove signin schema (use Signin entity)

* add schemas refs, fix Packed type

* wip PackedHoge => Packed<'Hoge'>

* add Packed type

* note-reaction

* user

* user-group

* user-list

* note

* app, messaging-message

* notification

* drive-file

* drive-folder

* following

* muting

* blocking

* hashtag

* page

* app (with modifying schema)

* import user?

* channel

* antenna

* clip

* gallery-post

* emoji

* Packed

* reversi-matching

* update stream.ts

* https://github.com/misskey-dev/misskey/pull/7769#issuecomment-917542339

* fix lint

* clean up?

* add app

* fix

* nanka iroiro

* wip

* wip

* fix lint

* fix loginId

* fix

* refactor

* refactor

* remove follow action

* clean up

* Revert "remove follow action"

This reverts commit defbb416480905af2150d1c92f10d8e1d1288c0a.

* Revert "clean up"

This reverts commit f94919cb9cff41e274044fc69c56ad36a33974f2.

* remove fetch specification

* renoteの条件追加

* apiFetch => cli

* bypass fetch?

* fix

* refactor: use path alias

* temp: add submodule

* remove submodule

* enhane: unison-reloadに指定したパスに移動できるように

* null

* null

* feat: ログインするアカウントのIDをクエリ文字列で指定する機能

* null

* await?

* rename

* rename

* Update read.ts

* merge

* get-note-summary

* fix

* swパッケージに

* add missing packages

* fix getNoteSummary

* add webpack-cli

* ✌️

* remove plugins

* sw-inject分離したがテストしてない

* fix notification.vue

* remove a blank line

* disconnect intersection observer

* disconnect2

* fix notification.vue

* remove a blank line

* disconnect intersection observer

* disconnect2

* fix

* ✌️

* clean up config

* typesを戻した

* Update packages/client/src/components/notification.vue

Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>

* disconnect

* oops

* Failed to load the script unexpectedly回避
sw.jsとlib.tsを分離してみた

* truncate notification

* Update packages/client/src/ui/_common_/common.vue

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

* clean up

* clean up

* キャッシュ対策

* Truncate push notification message

* クライアントがあったらストリームに接続しているということなので通知しない判定の位置を修正

* components/drive-file-thumbnail.vue

* components/drive-select-dialog.vue

* components/drive-window.vue

* merge

* fix

* Service Workerのビルドにesbuildを使うようにする

* return createEmptyNotification()

* fix

* i18n.ts

* update

* ✌️

* remove ts-loader

* fix

* fix

* enhance: Service Workerを常に登録するように

* pollEnded

* URLをsw.jsに戻す

* clean up

Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2022-04-30 21:52:07 +09:00
tamaina
83096440cc enhance: ドライブに画像ファイルをアップロードするときオリジナル画像を破棄してwebpublicのみ保持するオプション (#8216)
* wip

* Update packages/client/src/os.ts

Co-authored-by: tamaina <tamaina@hotmail.co.jp>

* メニューをComposition API化、switchアイテム追加
クライアントサイド画像圧縮の準備

* メニュー型定義を分離 (TypeScriptの型支援が効かないので)

* disabled

* make keepOriginal to follow setting value

* ✌️

* fix

* fix

* ✌️

* WEBP

* aaa

* ✌️

* webp

* lazy load browser-image-resizer

* rename

* rename 2

* Fix

* clean up

* add comment

* clean up

* jpeg, pngにもどす

* fix

* fix name

* webpでなくする ただしサムネやプレビューはwebpのまま (テスト)

* 動画サムネイルはjpegに

* エラーハンドリング

* ✌️

* v2.2.1-misskey-beta.2

* browser-image-resizer#v2.2.1-misskey.1

* ✌️

* fix alert

* update browser-image-resizer to v2.2.1-misskey.2

* lockfile

Co-authored-by: mei23 <m@m544.net>
Co-authored-by: MeiMei <30769358+mei23@users.noreply.github.com>
2022-04-28 11:14:03 +09:00
Johann150
0396792209 fix: Promises -> Promise (#8545) 2022-04-25 15:14:13 +09:00
syuilo
4bf45e968e refactor: use structuredClone for deep clone 2022-04-23 12:38:02 +09:00
Johann150
b68ac308ec await promises (#8519) 2022-04-19 18:46:41 +09:00
syuilo
8609c11944 refactor 2022-04-17 21:01:02 +09:00
syuilo
7b21b72c62 improve webhook 2022-04-03 22:36:30 +09:00
syuilo
2e9afc526d fix types 2022-04-03 16:30:22 +09:00
syuilo
f4f6a76ecc chore: fix lint 2022-04-03 15:33:22 +09:00
syuilo
8b2a0a5773 feat: Webhook (#8457)
* feat: introduce webhook

* wip

* wip

* wip

* Update CHANGELOG.md
2022-04-02 15:28:49 +09:00
Johann150
5421d6f659 limit federation of reactions on direct notes (#8448) 2022-03-27 13:57:04 +09:00
syuilo
54e1c7f60e perf(server): use cached user info in getUserFromApId 2022-03-26 19:09:57 +09:00
syuilo
523ee14a73 refactor: migrate to typeorm 3.0 (#8443)
* wip

* wip

* wip

* Update following.ts

* wip

* wip

* wip

* Update resolve-user.ts

* maxQueryExecutionTime

* wip

* wip
2022-03-26 15:34:00 +09:00
syuilo
4a00a85879 .js 2022-03-25 16:35:24 +09:00
syuilo
921299b02f perf(server): refactor and performance improvements 2022-03-25 16:27:41 +09:00
Ehsan Javadynia
441517b73b Resolve #7208 (#7226)
add decrement replies count on delete note and a test for that
2022-03-22 22:48:33 +09:00
syuilo
a32a3bc5c9 perf(server): disable some antenna features to improve performance 2022-03-22 00:07:43 +09:00
syuilo
5e9a8ce883 perf(server): reduce db query 2022-03-21 20:43:43 +09:00
dogcraft
b73ceaa4d2 Fix: "Adding email to profile ends in error" (#8405) 2022-03-14 22:57:55 +09:00
syuilo
3b95fce051 fix federation chart 2022-03-08 22:56:46 +09:00
syuilo
e3afe9fd82 delete needless instance drive columns 2022-03-07 21:20:14 +09:00
syuilo
13dfafb1dd feat: add active to federation chart 2022-03-07 15:10:16 +09:00
syuilo
3b86bdf18c feat: アンケート終了通知
Resolve #4664
2022-03-06 16:06:27 +09:00
syuilo
5ab7362d4c fix query error 2022-03-04 18:18:37 +09:00
syuilo
2606e10d55 enhance(chart): better federation pub/sub calculation 2022-03-04 16:26:10 +09:00
syuilo
94f294da59 fix federation chart pubsub 2022-03-04 15:32:50 +09:00
syuilo
d8c2d19d67 fix esm 2022-03-01 03:34:40 +09:00
syuilo
94228778c9 refactor: Use ESM (#8358)
* wip

* wip

* fix

* clean up

* Update tsconfig.json

* Update activitypub.ts

* wip
2022-02-27 11:07:39 +09:00
syuilo
bf72af1289 Merge branch 'develop' of https://github.com/misskey-dev/misskey into develop 2022-02-23 21:31:51 +09:00
Johann150
95e4425a79 fix: also recognize "shortcut icon" favicon (#8220)
* also recognize "shortcut icon" favicon

Not using querySelector for this because it uses jsdom which might be slower.
Reversing the order because WHATWG says the last appropriate link should be used.

* also fetchIconUrl

* br

* improve readability

* fix

* フォールバックにhrefの評価を含める

* fix val name

* 将来的な拡張を考えたコードにした

Co-authored-by: tamaina <tamaina@hotmail.co.jp>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2022-02-23 20:17:43 +09:00
syuilo
2f83378acc feat: add pub & sub item for federation chart 2022-02-23 16:17:16 +09:00
tamaina
706c1b054d SchemaTypeの型計算量を削減 (#8332)
* schema typeの型計算量を削減

* reduce some type error

* wip

* fix

* clean up

* more shrink
2022-02-19 23:21:28 +09:00
syuilo
036c9571e2 refacator: fix typw 2022-02-19 14:53:33 +09:00
syuilo
81c7db0744 refactor: use ajv instead of cafy (#8324)
* wip

* wip

* Update abuse-user-reports.ts

* Update files.ts

* Update list-remote.ts

* Update list.ts

* Update show-users.ts

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* Update update.ts

* Update search.ts

* Update reactions.ts

* Update search.ts

* wip

* wip

* wip

* wip

* Update update.ts

* Update relation.ts

* Update available.ts

* wip

* wip

* wip

* Update packages/backend/src/server/api/define.ts

Co-authored-by: Johann150 <johann.galle@protonmail.com>

* Update define.ts

* Update define.ts

* typo

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* Update update.ts

* wip

* Update signup.ts

* Update call.ts

* minimum for limit

* type

* remove needless annotation

* wip

* Update signup.ts

* wip

* wip

* fix

* Update create.ts

Co-authored-by: Johann150 <johann.galle@protonmail.com>
2022-02-19 14:05:32 +09:00
syuilo
9b76f8d963 refactor: better getChart result type 2022-02-18 22:29:23 +09:00
syuilo
4a24258007 refactor: fix types 2022-02-13 12:46:52 +09:00
syuilo
f3853f76af refactor: fix types 2022-02-13 01:39:58 +09:00
syuilo
48fe5b1499 enhance: improve federation chart 2022-02-10 17:45:12 +09:00
syuilo
94365e97e9 fix(server): チャートのcleanでエラーが出る可能性がある問題を修正 2022-02-09 03:55:49 +09:00
syuilo
30a153e6ee fix(server): チャートのresyncでエラーが出る問題を修正
Fix #8274
2022-02-09 03:51:43 +09:00
syuilo
4d05c3e8a9 feat: introduce intersection calculation of charts 2022-02-09 03:46:58 +09:00
syuilo
61f855429f feat: improve federation chart 2022-02-08 23:43:51 +09:00
syuilo
756201ebef feat: notes/instance/perUserNotesチャートに添付ファイル付きノートの数を追加 2022-02-08 23:12:37 +09:00
syuilo
74f66c6a62 chore: remove unused code 2022-02-08 22:49:44 +09:00
syuilo
06180d1331 fix 2022-02-06 08:39:23 +09:00
syuilo
b0da30469d imprpve active users chart 2022-02-06 06:24:06 +09:00
syuilo
ed86093869 fix chart clean 2022-02-06 02:16:52 +09:00
syuilo
eaad6e188c Improve chart engine (#8253)
* wip

* wip

* wip

* wip

* wip

* wip

* wip

* Update core.ts

* wip

* wip

* #7361

* delete network chart

* federationChart強化 apRequestChart追加

* tweak
2022-02-06 00:13:52 +09:00
syuilo
34449ec0b2 use date-fns 2022-02-04 10:41:27 +09:00
syuilo
f6184239cf refactor 2022-02-03 21:38:57 +09:00
syuilo
dcd2a3037f refactor 2022-02-03 02:41:22 +09:00
syuilo
1e31e8d1ca refactor(backend): use insert instead of save 2022-01-26 00:51:26 +09:00
MeiMei
3150708d7a refactor, enhance: ドライブ引数のオブジェクト化, 追加時のcomment指定 (#8180)
* refactor: ドライブの引数をオブジェクト化する Resolve #8177

* Resolve #8181

* fix

* archivePath
2022-01-23 22:52:35 +09:00
syuilo
e1b9c22874 enhance: convert svg to png of custom emojis 2022-01-21 18:47:02 +09:00
syuilo
93f79c1d8c refactor(server): use named export 2022-01-20 02:43:13 +09:00
syuilo
3230cdaa4f feat(server): store mime type of webpublic 2022-01-20 02:40:13 +09:00
syuilo
6c01a2aec1 refactor(server): use insert instead of save 2022-01-20 02:33:20 +09:00
tamaina
66ef4f1ebe refactor: APIエンドポイントファイルの定義を良い感じにする (#8154)
* Fix API Schema Error

* Delete SimpleSchema/SimpleObj
and Move schemas to dedicated files

* Userのスキーマを分割してみる

* define packMany type

* add ,

* Ensure enum schema and Make "as const" put once

* test?

* Revert "test?"

This reverts commit 97dc9bfa70851bfb7d1cf38e883f8df20fb78b79.

* Revert "Fix API Schema Error"

This reverts commit 21b6176d974ed8e3eb73723ad21a105c5d297323.

* ✌️

* clean up

* test?

* wip

* wip

* better schema def

* ✌️

* fix

* add minLength property

* wip

* wip

* wip

* anyOf/oneOf/allOfに対応? ~ relation.ts

* refactor!

* Define MinimumSchema

* wip

* wip

* anyOf/oneOf/allOfが動作するようにUnionSchemaTypeを修正

* anyOf/oneOf/allOfが動作するようにUnionSchemaTypeを修正

* Update packages/backend/src/misc/schema.ts

Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>

* fix

* array oneOfをより正確な型に

* array oneOfをより正確な型に

* wip

* ✌️

* なんかもういろいろ

* remove

* very good schema

* api schema

* wip

* refactor: awaitAllの型定義を変えてみる

* fix

* specify types in awaitAll

* specify types in awaitAll

* ✌️

* wip

* ...

* ✌️

* AllowDateはやめておく

* 不必要なoptional: false, nullable: falseを廃止

* Packedが展開されないように

* 続packed

* wip

* define note type

* wip

* UserDetailedをMeDetailedかUserDetailedNotMeかを区別できるように

* wip

* wip

* wip specify user type of other schemas

* ok

* convertSchemaToOpenApiSchemaを改修

* convertSchemaToOpenApiSchemaを改修

* Fix

* fix

* ✌️

* wip

* 分割代入ではなくallOfで定義するように

Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
2022-01-18 22:27:10 +09:00
syuilo
9117fd7a06 bye reversi 2022-01-12 17:34:53 +09:00
tamaina
a26ab96021 enhance: 許可されていないファイルタイプでは、オブジェクトストレージのファイル名に拡張子を付与しないように (#8108)
* 許可されていないファイルタイプでは、オブジェクトストレージのファイル名に拡張子を付与しないように

* add comment
2022-01-03 07:35:02 +09:00
syuilo
cbce987453 refactor(server): use insert instead of save 2022-01-03 03:17:16 +09:00
syuilo
21a7cb9546 refactor(server): use insert instead of save 2022-01-03 02:20:30 +09:00
syuilo
6bd6b72e1b Revert "revert d53795184"
This reverts commit aedbab17cc400ae7ac17498463504f40646e8673.
2022-01-01 22:25:30 +09:00
tamaina
336c7e0ebc wip (#8101) 2022-01-01 18:00:53 +09:00
syuilo
e50eff9de7 revert d53795184 2021-12-29 17:21:08 +09:00
syuilo
af1281fcb6 refactor 2021-12-26 12:08:22 +09:00
syuilo
7b9f7fb060 enhance(server): better content type detection 2021-12-26 01:43:51 +09:00
tamaina
748547fbb4 Truncate push notification message (#8089)
* Truncate push notification message

* fix
2021-12-25 02:01:35 +09:00
syuilo
89bbcf1807 enhance(backend): improve chart engine 2021-12-14 18:12:37 +09:00
syuilo
9b8d526ed0 fix lint 2021-12-09 23:58:30 +09:00
syuilo
ba06b44bff refactoring
https: //github.com/misskey-dev/misskey/pull/7901
Co-Authored-By: MeiMei <30769358+mei23@users.noreply.github.com>
2021-12-03 11:43:05 +09:00
xianon
8f55ef86df fix: 画像ファイルの縦横サイズの取得で Exif Orientation を考慮する (#8014)
* 画像ファイルの縦横サイズの取得で Exif Orientation を考慮する

* test: Add rotate.jpg test

* Webpublic 画像を返す時のみ Exif Orientation を考慮して縦横サイズを返す

* test: Support orientation
2021-12-03 11:19:28 +09:00
nullobsi
d6f087495e feat: Undo Accept (#7980)
* allow breaking of follow

* send undo

* delete by using reject follow
2021-12-03 11:14:44 +09:00
syuilo
5b2d5421c2 refactor 2021-11-12 21:11:21 +09:00
syuilo
a39c964847 viaMobileフラグ廃止
Close #7965
2021-11-12 15:11:20 +09:00
syuilo
713ff43e9b fix lint errors 2021-11-12 10:52:10 +09:00
syuilo
14148f6c4a refactoring
Resolve #7779
2021-11-12 02:02:25 +09:00