From 81ea683f9f0d0a419d815a5f2afca89b2536e68d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=81=8B=E3=81=B2=E3=82=8F=E3=81=974=EF=BC=88=E3=83=90?= =?UTF-8?q?=E3=83=BC=E3=82=B8=E3=83=A7=E3=83=B31=EF=BC=89?= Date: Sun, 21 Apr 2019 23:58:15 +0900 Subject: [PATCH] Docker: Remove quotes in docker_example.env (#4765) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Docker does not parse quotes in env_file. As follows if enclosed in quotation marks. docker_example.env: POSTGRES_PASSWORD="password" Environment value in Misskey container: $ echo $POSTGRES_PASSWORD "password" Some users may see this behavior as unexpected. Dockerはenv_fileのクォーテーションマークを解析しません。 もし値がクォーテーションマークで囲まれていた場合は以下のような動作になります。 docker_example.env: POSTGRES_PASSWORD="password" Misskeyのコンテナ内の環境変数: $ echo $POSTGRES_PASSWORD "password" この動作を予期しない動作のように思うユーザーがいるかもしれません。 --- .config/docker_example.env | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.config/docker_example.env b/.config/docker_example.env index 411d93659..7a0261524 100644 --- a/.config/docker_example.env +++ b/.config/docker_example.env @@ -1,5 +1,4 @@ # db settings -POSTGRES_PASSWORD="example-misskey-pass" -POSTGRES_USER="example-misskey-user" -POSTGRES_DB="misskey" - +POSTGRES_PASSWORD=example-misskey-pass +POSTGRES_USER=example-misskey-user +POSTGRES_DB=misskey