e88f36f72b
Non-Create/Listen activities had their associated object field normalized and fetched, but only to use their `id` field, which is both slow and redundant. This also failed on Undo activities, which delete the associated object/activity in database. Undo activities will now render properly and database loads should improve ever so slightly.
98 lines
3 KiB
Elixir
98 lines
3 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.ActivityPub.ObjectViewTest do
|
|
use Pleroma.DataCase
|
|
import Pleroma.Factory
|
|
|
|
alias Pleroma.Object
|
|
alias Pleroma.Web.ActivityPub.ObjectView
|
|
alias Pleroma.Web.CommonAPI
|
|
|
|
test "renders a note object" do
|
|
note = insert(:note)
|
|
|
|
result = ObjectView.render("object.json", %{object: note})
|
|
|
|
assert result["id"] == note.data["id"]
|
|
assert result["to"] == note.data["to"]
|
|
assert result["content"] == note.data["content"]
|
|
assert result["type"] == "Note"
|
|
assert result["@context"]
|
|
end
|
|
|
|
test "renders a note activity" do
|
|
note = insert(:note_activity)
|
|
object = Object.normalize(note, fetch: false)
|
|
|
|
result = ObjectView.render("object.json", %{object: note})
|
|
|
|
assert result["id"] == note.data["id"]
|
|
assert result["to"] == note.data["to"]
|
|
assert result["object"]["type"] == "Note"
|
|
assert result["object"]["content"] == object.data["content"]
|
|
assert result["type"] == "Create"
|
|
assert result["@context"]
|
|
end
|
|
|
|
describe "note activity's `replies` collection rendering" do
|
|
setup do: clear_config([:activitypub, :note_replies_output_limit], 5)
|
|
|
|
test "renders `replies` collection for a note activity" do
|
|
user = insert(:user)
|
|
activity = insert(:note_activity, user: user)
|
|
|
|
{:ok, self_reply1} =
|
|
CommonAPI.post(user, %{status: "self-reply 1", in_reply_to_status_id: activity.id})
|
|
|
|
replies_uris = [self_reply1.object.data["id"]]
|
|
result = ObjectView.render("object.json", %{object: refresh_record(activity)})
|
|
|
|
assert %{"type" => "Collection", "items" => ^replies_uris} =
|
|
get_in(result, ["object", "replies"])
|
|
end
|
|
end
|
|
|
|
test "renders a like activity" do
|
|
note = insert(:note_activity)
|
|
object = Object.normalize(note, fetch: false)
|
|
user = insert(:user)
|
|
|
|
{:ok, like_activity} = CommonAPI.favorite(user, note.id)
|
|
|
|
result = ObjectView.render("object.json", %{object: like_activity})
|
|
|
|
assert result["id"] == like_activity.data["id"]
|
|
assert result["object"] == object.data["id"]
|
|
assert result["type"] == "Like"
|
|
end
|
|
|
|
test "renders an announce activity" do
|
|
note = insert(:note_activity)
|
|
object = Object.normalize(note, fetch: false)
|
|
user = insert(:user)
|
|
|
|
{:ok, announce_activity} = CommonAPI.repeat(note.id, user)
|
|
|
|
result = ObjectView.render("object.json", %{object: announce_activity})
|
|
|
|
assert result["id"] == announce_activity.data["id"]
|
|
assert result["object"] == object.data["id"]
|
|
assert result["type"] == "Announce"
|
|
end
|
|
|
|
test "renders an undo announce activity" do
|
|
note = insert(:note_activity)
|
|
user = insert(:user)
|
|
|
|
{:ok, announce} = CommonAPI.repeat(note.id, user)
|
|
{:ok, undo} = CommonAPI.unrepeat(note.id, user)
|
|
|
|
result = ObjectView.render("object.json", %{object: undo})
|
|
|
|
assert result["id"] == undo.data["id"]
|
|
assert result["object"] == announce.data["id"]
|
|
assert result["type"] == "Undo"
|
|
end
|
|
end
|