Cleaned up FEP-fffd commits a bit

CHANGELOG.md

@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ## Unreleased
 
 ## Added
+- Support for [FEP-fffd](https://codeberg.org/fediverse/fep/src/branch/main/fep/fffd/fep-fffd.md) (proxy objects)
  
 ## Changed
 

lib/pleroma/web/activity_pub/object_validators/article_note_page_validator.ex

@@ -53,12 +53,11 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.ArticleNotePageValidator do
 
   defp fix_url(%{"url" => url} = data) when is_bitstring(url), do: data
   defp fix_url(%{"url" => url} = data) when is_map(url), do: Map.put(data, "url", url["href"])
+
   defp fix_url(%{"url" => url} = data) when is_list(url) do
-    if is_map(List.first(url)) do
+    data
-      Map.put(data, "url", List.first(url)["href"])
+    |> Map.put("url", List.first(url))
-    else
+    |> fix_url()
-      Map.put(data, "url", List.first(url))
-    end
   end
 
   defp fix_url(data), do: data

test/pleroma/web/activity_pub/object_validators/article_note_page_validator_test.exs

@@ -50,14 +50,17 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.ArticleNotePageValidatorTest
     end
 
     test "note with url array validates if contains a link object", %{note: note} do
-      note = Map.put(note, "url", [%{
+      note =
-        "type" => "Link",
+        Map.put(note, "url", [
-        "href" => "https://remote.example/link"
+          %{
-      }])
+            "type" => "Link",
+            "href" => "https://remote.example/link"
+          }
+        ])
+
       %{valid?: true} = ArticleNotePageValidator.cast_and_validate(note)
     end
 
-
     test "a note with a language validates" do
       insert(:user, %{ap_id: "https://mastodon.social/users/akkoma_ap_integration_tester"})
       note = File.read!("test/fixtures/mastodon/note_with_language.json") |> Jason.decode!()