limepotato/akkoma
1
0
Fork 0
Code Pull requests Activity

Better way of getting keys

Browse source 
I used keyword_list[:key], but if the key doesn't exist, it will return nil. I actually expect a list and further down the code I use that list.
I believe the key should always be present, but in case it's not, it's better to return an empty list instead of nil. That way the code wont fail further down the line.
This commit is contained in:
Ilja 2022-02-22 18:18:10 +01:00
parent 75ea766824
commit 81afaee374
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/pleroma/config/deprecation_warnings.ex
View file

@ -21,7 +21,7 @@ defmodule Pleroma.Config.DeprecationWarnings do
] ]
def check_exiftool_filter do def check_exiftool_filter do
filters = Config.get([Pleroma.Upload])[:filters] filters = Config.get([Pleroma.Upload]) |> Keyword.get(:filters, [])
if Pleroma.Upload.Filter.Exiftool in filters do if Pleroma.Upload.Filter.Exiftool in filters do
Logger.warn(""" Logger.warn("""

2
test/pleroma/config/deprecation_warnings_test.exs
View file

@ -51,7 +51,7 @@ defmodule Pleroma.Config.DeprecationWarningsTest do
capture_log(fn -> DeprecationWarnings.warn() end) capture_log(fn -> DeprecationWarnings.warn() end)
assert Config.get([Pleroma.Upload])[:filters] == expected_config assert Config.get([Pleroma.Upload]) |> Keyword.get(:filters, []) == expected_config
end end
test "doesn't give a warning with correct config" do test "doesn't give a warning with correct config" do