limepotato/akkoma
1
0
Fork 0
Code Pull requests Activity

Fix eratic test for POST /api/pleroma/admin/reports/:id/notes

Browse source 
It retrieved two ReportNotes and then checked one of them. But the order isn't guaranteed, while the test tested on the content of the first ReportNote.

I made the test on the content more generic
This commit is contained in:
Ilja 2022-04-05 13:21:09 +02:00
parent d7c53da77a
commit 5f37db330f
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
test/pleroma/web/admin_api/controllers/report_controller_test.exs
View file

@ -355,7 +355,6 @@ defmodule Pleroma.Web.AdminAPI.ReportControllerTest do
} = note } = note
end end
@tag :erratic
test "it returns reports with notes", %{conn: conn, admin: admin} do test "it returns reports with notes", %{conn: conn, admin: admin} do
conn = get(conn, "/api/pleroma/admin/reports") conn = get(conn, "/api/pleroma/admin/reports")
@ -364,7 +363,8 @@ defmodule Pleroma.Web.AdminAPI.ReportControllerTest do
[note, _] = notes [note, _] = notes
assert note["user"]["nickname"] == admin.nickname assert note["user"]["nickname"] == admin.nickname
assert note["content"] == "this is disgusting!" # We use '=~' because the order of the notes isn't guaranteed
assert note["content"] =~ "this is disgusting"
assert note["created_at"] assert note["created_at"]
assert response["total"] == 1 assert response["total"] == 1
end end